Async await support #5537
Merged
Async await support #5537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
Jul 11, 2022
| @@ -1864,7 +1864,34 @@ and type_expect ?in_function ?recarg env sexp ty_expected = | |||
| type_expect_ ?in_function ?recarg env sexp ty_expected | |||
| ) | |||
| in | |||
| Cmt_format.set_saved_types | |||
| let () = | |||
There was a problem hiding this comment.
Where is the best place to perform this check? Performance?
Use the existing convention in the printer to determine a conventional meaning to the result. `x => y => 3` is formatted as `(x,y) => 3` so `@async x => y => 3` adds a promise to the result `3`.
cristianoc
force-pushed
the
async-await-support
branch
from
5210e3c to
8a38fb4
Compare
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for async/await.
This was taken from cristianoc/rescript-compiler-experiments#1